Report information
The Basics
Id:
28194
Status:
resolved
Users:
cathya: 5 minutes
each: -10 minutes
Priority:
Medium/Medium
Queue:
bind9-public
People
Owner:
Michał Kępień <michal@isc.org>
Requestors:
<shane@isc.org>
Cc:
AdminCc:
BugTracker
Version Fixed:
9.9.12, 9.10.7, 9.11.3, 9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
bug
Dates
Created:Wed, 29 Feb 2012 11:11:55 -0500
Updated:Thu, 17 Aug 2017 03:25:17 -0400
Closed:Thu, 17 Aug 2017 03:25:17 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Wed, 29 Feb 2012 11:11:55 -0500 <shane@isc.org> - Ticket created
Subject: Abnormal exit in nsupdate when missing a label
Date: Wed, 29 Feb 2012 17:11:18 +0100
To: bind9-bugs@isc.org
From: Shane Kerr <shane@isc.org>

Hello, I was using nsupdate and it crashed on me: shane@mercury:~$ nsupdate > update delete carbon.time-travellers.nl.eu.org. 3600 IN AAAA 2a02:2770::21a:4aff:fea3:eeaa > update delete carbon.time-travellers.nl.eu.org. 3600 IN A 46.19.37.141 > update add c..time-travellers.nl.eu.org. 3600 IN AAAA 2a02:2770::21a:4aff:fea3:eeaa dns_name_fromtext: empty label A typo should not cause the program to exit. -- Shane
  Wed, 29 Feb 2012 13:37:24 -0500 Cathy Almond <cathya@isc.org> - Correspondence added 5 minutes

On Wed Feb 29 16:11:55 2012, shane@isc.org wrote:
> Hello,
>
> I was using nsupdate and it crashed on me:
>
> shane@mercury:~$ nsupdate
> > update delete carbon.time-travellers.nl.eu.org. 3600 IN AAAA
> 2a02:2770::21a:4aff:fea3:eeaa
> > update delete carbon.time-travellers.nl.eu.org. 3600 IN A
> 46.19.37.141
> > update add c..time-travellers.nl.eu.org. 3600 IN AAAA
> 2a02:2770::21a:4aff:fea3:eeaa
> dns_name_fromtext: empty label
>
> A typo should not cause the program to exit.
>
> --
> Shane
>

Version?

Wed, 29 Feb 2012 13:37:24 -0500 The RT System itself - Status changed from 'new' to 'open'
Thu, 01 Mar 2012 12:10:09 -0500 Scott Mann <smann@isc.org> - Priority P2 Normal added
Thu, 01 Mar 2012 12:10:09 -0500 Scott Mann <smann@isc.org> - Severity S2 Normal added
Mon, 12 Jun 2017 06:29:51 -0400 Michał Kępień <michal@isc.org> - Queue changed from #6 to #7
Mon, 12 Jun 2017 21:55:45 -0400 Evan Hunt <Evan_Hunt@isc.org> - Adjusted time worked by -10 minutes -10 minutes
Mon, 12 Jun 2017 21:55:45 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Michał Kępień <michal@isc.org>
Tue, 13 Jun 2017 04:55:07 -0400 Michał Kępień <michal@isc.org> - Untaken
Tue, 20 Jun 2017 17:51:47 -0400 Brian Conry <bconry@isc.org> - Status changed from 'open' to 'review'
  Sun, 25 Jun 2017 20:30:32 -0400 Mark Andrews <marka@isc.org> - Correspondence added

I don't see any test cases for this error handling.
Sun, 25 Jun 2017 20:30:33 -0400 The RT System itself - Status changed from 'review' to 'open'
Sun, 25 Jun 2017 20:31:12 -0400 Mark Andrews <marka@isc.org> - Given to Michał Kępień <michal@isc.org>
  Sun, 25 Jun 2017 20:44:08 -0400 Mark Andrews <marka@isc.org> - Correspondence added

On Sun Jun 25 14:30:32 2017, marka wrote: > I don't see any test cases for this error handling. Additionally there is a case for continuing to fail in non-iteractive mode. We may want to add a interactive mode flag to facilite testing. We may also want to add a "fail on error" flag (c.f. "sh -e") so that errors in programs feeding nsupdate are easily detected.
  Sun, 25 Jun 2017 20:46:14 -0400 Mark Andrews <marka@isc.org> - Correspondence added

Note 45417 also updates get_addresses prototype.
Sun, 25 Jun 2017 20:46:28 -0400 Mark Andrews <marka@isc.org> - Reference to #45417: added
Thu, 29 Jun 2017 18:35:58 -0400 Evan Hunt <Evan_Hunt@isc.org> - Status changed from 'open' to 'review'
Thu, 29 Jun 2017 18:35:58 -0400 Evan Hunt <Evan_Hunt@isc.org> - Queue changed from #7 to bind9-public
  Wed, 16 Aug 2017 04:21:23 -0400 Michał Kępień <michal@isc.org> - Correspondence added

Added system tests, writing which only became possible after adding a -i command line switch forcing interactive mode. nsupdate already bails on error in non-interactive mode, so no further command line switches were added. rt28194 was rebased as agreed with Mark on Jabber back in June, due to conflicting changes to bin/nsupdate/nsupdate.c and the nsupdate system test which were merged in the meantime. Please review.
Wed, 16 Aug 2017 04:21:34 -0400 Michał Kępień <michal@isc.org> - Untaken
  Thu, 17 Aug 2017 01:22:35 -0400 Mark Andrews <marka@isc.org> - Correspondence added

On Tue Aug 15 22:21:23 2017, michal wrote: > Added system tests, writing which only became possible after adding a -i > command line switch forcing interactive mode. nsupdate already bails on > error in non-interactive mode, so no further command line switches were > added. > > rt28194 was rebased as agreed with Mark on Jabber back in June, due to > conflicting changes to bin/nsupdate/nsupdate.c and the nsupdate system > test which were merged in the meantime. > > Please review. looks fine
Thu, 17 Aug 2017 01:30:00 -0400 Mark Andrews <marka@isc.org> - Given to Michał Kępień <michal@isc.org>
Thu, 17 Aug 2017 01:30:12 -0400 Mark Andrews <marka@isc.org> - Area bug added
  Thu, 17 Aug 2017 03:25:16 -0400 Michał Kępień <michal@isc.org> - Correspondence added

4683. [bug] Prevent nsupdate from immediately exiting on invalid user input in interactive mode. [RT #28194] 9.9.12, 9.10.7, 9.11.3, 9.12.0
Thu, 17 Aug 2017 03:25:17 -0400 Michał Kępień <michal@isc.org> - Status changed from 'review' to 'resolved'
Thu, 17 Aug 2017 03:25:17 -0400 Michał Kępień <michal@isc.org> - Version Fixed 9.9.12, 9.10.7, 9.11.3, 9.12.0 added