Report information
The Basics
Id:
46853
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
Owner:
Nobody in particular
Requestors:
Petr Menšík <pemensik@redhat.com>
Cc:
AdminCc:
BugTracker
Version Fixed:
9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.1
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
Other
Attachments
0001-Support-more-recent-atf-library-and-kyua-tool.patch
Dates
Created:Thu, 14 Dec 2017 10:43:06 -0500
Updated:Mon, 01 Jan 2018 18:25:08 -0500
Closed:Mon, 01 Jan 2018 18:25:08 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Thu, 14 Dec 2017 10:43:06 -0500 Petr Menšík <pemensik@redhat.com> - Ticket created
Subject: Support for more recent atf library and kyua tool
Date: Thu, 14 Dec 2017 16:42:58 +0100
To: bind-suggest@isc.org
From: "Petr Menšík" <pemensik@redhat.com>

Hi! In Fedora is packaged libatf-c library with version 0.20. It no longer contains atf-run tool. I would like to propose usage of more recent library with bind. My patch attaches support for kuya instead of atf-run and modification to support it from make unit. -- Petr Menšík Software Engineer Red Hat, http://www.redhat.com/ email: pemensik@redhat.com PGP: 65C6C973
0001-Support-more-recent-atf-library-and-kyua-tool.patch

Message body is not shown because sender requested not to inline it.

  Thu, 14 Dec 2017 14:38:05 -0500 Evan Hunt <each@isc.org> - Correspondence added
CC:
To: "Petr Menšík via RT" <bind9-public@isc.org>
Date: Thu, 14 Dec 2017 19:38:03 +0000
From: "Evan Hunt" <each@isc.org>
Subject: Re: [ISC-Bugs #46853] Support for more recent atf library and kyua tool

> In Fedora is packaged libatf-c library with version 0.20. It no longer > contains atf-run tool. I would like to propose usage of more recent > library with bind. My patch attaches support for kuya instead of atf-run > and modification to support it from make unit. I love it when someone submits a patch for a thing I was about to do. I didn't get *you* anything for Christmas, though! Very sorry about that. :) Thanks very much, I'll review this.
Thu, 14 Dec 2017 14:38:05 -0500 The RT System itself - Status changed from 'new' to 'open'
  Thu, 14 Dec 2017 17:17:39 -0500 Mark Andrews <marka@isc.org> - Correspondence added

On Thu Dec 14 09:38:05 2017, each@isc.org wrote: > > In Fedora is packaged libatf-c library with version 0.20. It no longer > > contains atf-run tool. I would like to propose usage of more recent > > library with bind. My patch attaches support for kuya instead of atf-run > > and modification to support it from make unit. > > I love it when someone submits a patch for a thing I was about to do. > I didn't get *you* anything for Christmas, though! Very sorry about > that. :) > > Thanks very much, I'll review this. > The bash constructs will need to be removed and use type instead of which. It's missing some Kyuafile files but we can create them. It's a very minimal change.
Thu, 28 Dec 2017 19:28:58 -0500 Mark Andrews <marka@isc.org> - Priority P2 Normal added
Thu, 28 Dec 2017 19:28:58 -0500 Mark Andrews <marka@isc.org> - Area Other added
Thu, 28 Dec 2017 19:28:59 -0500 Mark Andrews <marka@isc.org> - Severity S2 Normal added
  Thu, 28 Dec 2017 19:28:59 -0500 Mark Andrews <marka@isc.org> - Correspondence added

rt46853 ready for review.
Thu, 28 Dec 2017 19:29:00 -0500 Mark Andrews <marka@isc.org> - Status changed from 'open' to 'review'
Sat, 30 Dec 2017 09:40:14 -0500 Francis Dupont <Francis_Dupont@isc.org> - Taken
  Sat, 30 Dec 2017 09:44:17 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Fri Dec 29 00:28:59 2017, marka wrote: > rt46853 ready for review. => I applied the diff on the shell script of a copy of master (Kyuafile files where already installed). A "make unit" worked well so I am happy. I created a similar ticket for ISC DHCP to port this to it (to build ATF each time takes a long time0. Code OK. Please merge!
Sat, 30 Dec 2017 09:44:18 -0500 Francis Dupont <Francis_Dupont@isc.org> - Given to Mark Andrews <marka@isc.org>
  Sat, 30 Dec 2017 16:58:41 -0500 Mark Andrews <marka@isc.org> - Correspondence added
From: "Mark Andrews" <marka@isc.org>
Subject: Re: [ISC-Bugs #46853] Support for more recent atf library and kyua tool
To: bind9-public@isc.org
Date: Sun, 31 Dec 2017 08:58:35 +1100

The shell script had a number of errors. See the branch. -- Mark Andrews > On 31 Dec 2017, at 01:44, Francis Dupont via RT <bind9-public@isc.org> wrote: > >> On Fri Dec 29 00:28:59 2017, marka wrote: >> rt46853 ready for review. > > => I applied the diff on the shell script of a > copy of master (Kyuafile files where already installed). > > A "make unit" worked well so I am happy. > I created a similar ticket for ISC DHCP to port this > to it (to build ATF each time takes a long time0. > > Code OK. Please merge! > > > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46853
  Sun, 31 Dec 2017 05:45:28 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Sat Dec 30 21:58:41 2017, marka wrote: > The shell script had a number of errors. See the branch. => I looked at the branch. Where are the shell script problems?
  Sun, 31 Dec 2017 08:34:34 -0500 Mark Andrews <marka@isc.org> - Correspondence added
Date: Mon, 1 Jan 2018 00:34:24 +1100
To: bind9-public@isc.org
Subject: Re: [ISC-Bugs #46853] Support for more recent atf library and kyua tool
From: "Mark Andrews" <marka@isc.org>

If you had both kyua and atf-run installed both were run. With-atf=no still ran the tests. Bash vs sh. These were addressed on the branch. -- Mark Andrews > On 31 Dec 2017, at 21:45, Francis Dupont via RT <bind9-public@isc.org> wrote: > >> On Sat Dec 30 21:58:41 2017, marka wrote: >> The shell script had a number of errors. See the branch. > > => I looked at the branch. Where are the shell script problems? > > > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46853
  Sun, 31 Dec 2017 11:51:47 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Sun Dec 31 13:34:34 2017, marka wrote: > If you had both kyua and atf-run installed both were run. With-atf=no > still ran the tests. Bash vs sh. > > These were addressed on the branch. => I can't see a recent difference in the branch (last commit was on Friday so before I looked at it). So either I reviewed (and ported to ISC DHCP) the right script, or a push was missed...
Mon, 01 Jan 2018 18:25:04 -0500 Mark Andrews <marka@isc.org> - Version Fixed 9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.1 added
  Mon, 01 Jan 2018 18:25:05 -0500 Mark Andrews <marka@isc.org> - Correspondence added

4851. [port] Support using kyua as well as atf-run to run the unit tests. [RT #46853]
Mon, 01 Jan 2018 18:25:08 -0500 Mark Andrews <marka@isc.org> - Status changed from 'review' to 'resolved'
Mon, 01 Jan 2018 18:25:08 -0500 Mark Andrews <marka@isc.org> - Untaken