Hello Evan,

We are preparing a new release including bind soon. I would like to help
you any way I can. If there is anything I can help you with, please do
not hesitate to ask. Let me know when if you have anything to comment or
review.

Dne 25.3.2017 v 18:51 Evan Hunt via RT napsal(a):
> I've reviewed your patch, and made a few changes:
> 
> - reverted the changes to dns_view_addnewzones(), put the allow code back
>   into view.c.
Yes, I thought you would not like that move. I rechecked why did I move
it in the first place. It made some sense on bind 9.9, where it allowed
me to reuse making hashed file name from different places. It moved to
shared function isc_file_sanitize in bind 9.11, making such move
unnecessary change. I agree it is not necessary or useful in recent version.
> - moved your file_sanitize_legacy() function into view.c as nz_legacy()
> - made new-zones-directory a view option instead of options-only
I am not sure if that is really required. Every file in that directory
is named after single view and has to be as unique as is name of a view.
I think it would be more useful if you could override path to NZF/NZD
file used by that view. It would allow to configure one file shared
between views however, that is not wanted I think.

Do you have any use case when would it help to configure it per view?
> - added a dns_view_setnewzonedir() function. That's now used by nz_legacy()
>   to find the right place to put the files
Sure, it seems better than keeping temporary allocated path in nz_legacy()
> - added documentation of new-zones-directory
> - noticed that the existing documentation of NZD and NZF files was rather
>   poor, so expanded them
> - fixed the test to check for NZD instead of NZF when linked with LMDB
> 
> (I want to thank you for writing a test, that was particularly helpful.)
> 
> Since I changed your code a fair bit I'm going to ask one of my colleagues
> to review it too, but I expect this will be merged to our master branch (for
> 9.12.0) soon.
> 
> Thank you again for the contribution.

I am glad I could help.
Petr Mensik