On Fri, Sep 08, 2017 at 11:49:24AM +0000, Michał Kępień via RT wrote:
> I pushed three more trivial commits which take care of things that you
> seem to have missed.  If you left these changes out deliberately, feel
> free to revert them.

I did leave the sctx assignments in get_client() and get_worker() on
purpose, purely out of an abundance of caution. They're probably not
necessary, but seemed like cheap insurance.

> Other than that, the only outstanding item is that there is no
> rt45186_base tag.  However, I understand rt45186 will need to be rebased
> on top of current master anyway and thus I think it is okay to refrain
> from creating the tag until that happens.

We used to create _base tags for everything when we used CVS, and continued
the practice for a while after switching to git, but a few years ago we
agreed it wasn't necessary except when branching from a source other than
master. Ordinarily, "git diff master...<branch>" is the same as
"git diff <branch>_base".

> In other words, I think the changes are good to go in their current
> state, though please do not forget to eventually properly comment all
> functions defined in libns header files.

Thanks!