> I'd call this [cleanup] not [func], it's not in any way a user-visible
> change.

Agreed.  Is this already annotated as [func] anywhere?  rt46289 does not
seem to include a CHANGES update.  Did you just mean to point this out
_before_ CHANGES is updated?

> To quibble, I'd suggest moving it to lib/dns/nsec3.c and calling the
> function dns_nsec3param_salttotext().  The files in lib/dns/rdata are
> referenced via #include in code.c and called from lib/dns/rdata.c; it
> isn't a good fit to mix other stuff there.

Good point.  I think I originally put it into lib/dns/rdata because that
is what Mukund suggested in passing on Jabber and I have not bothered to
look around the tree for a better fit.  The changes I just pushed to
rt46289 address your comments, merge nsec3param_test.c into nsec3_test.c
and do some naming bikeshedding.  No functional changes were introduced.
Please review.