> On 28 Nov 2017, at 6:05 pm, Mukund Sivaraman via RT wrote: > > Now that isc_heap_delete() calls ->index(), is the change to rbtdb.c @@ > setsigningtime() still required? No. Changing that is followup work. > The change to isc_heap_delete() and testcase looks ok. In the testcase, > I'd assert e1.index != 0 in the first case as asserting index 1 looks > for implementation detail. But that's just IMO.. it look fine other than > that. > > Mukund > > > > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46709 -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org