On Thu Nov 30 08:01:12 2017, michal wrote:
> Pushed a commit which causes callback parameters to be passed explicitly
> instead of using a va_list.  As this is one of the options Ondřej
> suggested in his last message, I think rt46718 will be good to go once
> someone takes one final look at it.

A really minor nit, I would personally prefer to replace:

if (!commit || result != ISC_R_SUCCESS) {

with

if ((commit == NULL)[1] || (result != ISC_R_SUCCESS)[2]) {

with this explanation:

[1] to be consistent with rest of code where we use 'text != NULL' (as an example from this commit

[2] And the parentheses while not necessary just contributes to readability and prevents future mistakes.

~~~

But no strong feelings, just an observation.  It could be merged as is even without this change.  So, go ahead and merge at your discretion.