On Thu Nov 30 12:28:28 2017, michal wrote:
> > A really minor nit, I would personally prefer to replace:
> >
> > if (!commit || result != ISC_R_SUCCESS) {
> >
> > with
> >
> > if ((commit == NULL)[1] || (result != ISC_R_SUCCESS)[2]) {
> >
> > with this explanation:
> >
> > [1] to be consistent with rest of code where we use 'text != NULL'
> > (as an example from this commit
> 
> But "commit" is a boolean here.

Ah, ok, I haven't checked.

> > [2] And the parentheses while not necessary just contributes to
> > readability and prevents future mistakes.
> 
> This is not documented in our current coding style guidelines, so I
> decided against doing this.  Naturally, we can further discuss this
> suggestion elsewhere.

Ok, I'll add this to my All-Hands coding style updates.