On 15/12/2017 21:37, Mark Andrews via RT wrote:
> Ready for review.  Of the two cases where cfg_parser_mapadd is called only one needed reversal on failure.
Build error with --enable-developer on FC27:

gcc  -I/home/ray/src/bind9 -I../.. -I./include -I./unix/include -I.
-I/home/ray/src/bind9/lib/ns/include -I../../lib/ns/include
-I/home/ray/src/bind9/lib/dns/include -I../../lib/dns/include
-I/home/ray/src/bind9/lib/bind9/include -I../../lib/bind9/include
-I/home/ray/src/bind9/lib/isccfg/include -I../../lib/isccfg/include
-I/home/ray/src/bind9/lib/isccc/include -I../../lib/isccc/include
-I/home/ray/src/bind9/lib/isc/include -I../../lib/isc
-I../../lib/isc/include -I../../lib/isc/unix/include
-I../../lib/isc/pthreads/include -I../../lib/isc/x86_32/include
-I../../contrib/dlz/drivers/include
-I/home/ray/src/bind9/unit/atf/include -D_REENTRANT -DCONTRIB_DLZ
-DDLZ_FILESYSTEM   -DOPENSSL -DISC_MEM_DEFAULTFILL=1
-DISC_LIST_CHECKINIT=1 -DNS_HOOKS_ENABLE=1 -D_GNU_SOURCE
-DNS_HOOKS_ENABLE=1 -g -O2 -I/usr/include/libxml2   -fPIC  -W -Wall
-Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wformat
-Wpointer-arith -fno-strict-aliasing -fno-delete-null-pointer-checks
-Wshadow -Werror  \
	-DPRODUCT=\""BIND"\" \
	-DVERSION=\"9.13.0-dev\" -c ./server.c
./server.c: In function ‘do_addzone’:
./server.c:12758:16: error: declaration of ‘tresult’ shadows a previous
local [-Werror=shadow]
   isc_result_t tresult;
                ^~~~~~~
./server.c:12606:23: note: shadowed declaration is here
  isc_result_t result, tresult;
                       ^~~~~~~
cc1: all warnings being treated as errors