MIME-Version: 1.0
In-Reply-To: <rt-3.8.6-50549-1307068600-735.24733-5-0@isc.org>
References: <RT-Ticket-24733@isc.org> <4DE76CE2.3050600@redhat.com> <rt-3.8.6-50523-1307012362-704.24733-3-0@isc.org> <20110602142908.GA89544@isc.org> <rt-3.8.6-50534-1307024958-1605.24733-5-0@isc.org> <rt-3.8.6-50549-1307068600-735.24733-5-0@isc.org>
Message-ID: <4DF1F563.2020301@redhat.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [ISC-Bugs #24733] [PATCH] New dynamic_db database interface for BIND
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10
Date: Fri, 10 Jun 2011 12:43:47 +0200
To: bind-suggest@isc.org
Content-Transfer-Encoding: 7bit
From: Adam Tkac <atkac@redhat.com>
RT-Message-ID: <rt-3.8.6-50549-1307702655-1474.24733-0-0@isc.org>
Content-Length: 1523

On 06/03/2011 04:36 AM, Evan Hunt via RT wrote:
> Hi Adam,
>
> At a cursory glance this looks like quite good code, and we might indeed be 
> interested in accepting it into BIND 9, as it has at least one feature we had 
> hoped to support eventually (external database with the ability to serve 
> DNSSEC).
>
> We can't commit it in its current form for a few reasons:  first, there are no 
> tests or documentation; second, there is no sample driver we can provide as 
> guidance to implementors.  (The LDAP driver you pointed to is good, but it's 
> GPL, which means ISC is forbidden by corporate charter from shipping it.)
>
> We can probably help with tests and doc, but a sample driver with a BSD-
> compatible license would be a huge help, even if it only served static zones 
> (such as the one in bind9/bin/tests/system/dlzexternal/driver.c).
>
> Out of curiosity, why did you decide to add a new API and new 'dynamic-db' 
> configuration syntax instead of extending or improving the existing DLZ API?  
> Would a merged approach be workable?  Minimizing the number of different ways to 
> accomplish the same thing would be desirable, if feasible.
>
> I see a few trivial ISC code-style incompatibilities, but nothing to worry about 
> on that account.  I'm planning to commit your patch to a CVS branch for further 
> work, and will review the code in more detail later.

Hello Evan,

thanks for good suggestions, I will check if it is possible to
incorporate them into dyndb driver, stay tuned.

Regards, Adam