CC: undisclosed-recipients: ; MIME-Version: 1.0 In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 Content-Disposition: inline References: <4DE76CE2.3050600@redhat.com> <20110602142908.GA89544@isc.org> <4F703764.9080300@redhat.com> Message-ID: <20120326164236.GB81167@isc.org> Content-Type: text/plain; charset="utf-8" X-RT-Original-Encoding: utf-8 Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) by bugs.isc.org (Postfix) with ESMTP id 2877C20EE2C6 for ; Mon, 26 Mar 2012 16:42:38 +0000 (UTC) Received: from bikeshed.isc.org (bikeshed.isc.org [IPv6:2001:4f8:3:d::19]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mail.isc.org", Issuer "RapidSSL CA" (not verified)) by mx.pao1.isc.org (Postfix) with ESMTPS id B6ED3C9423 for ; Mon, 26 Mar 2012 16:42:36 +0000 (UTC) (envelope-from each@isc.org) Received: by bikeshed.isc.org (Postfix, from userid 10292) id AC9B2216C33; Mon, 26 Mar 2012 16:42:36 +0000 (UTC) Delivered-To: bind-suggest@bugs.isc.org User-Agent: Mutt/1.4.2.3i Subject: Re: [ISC-Bugs #24733] [PATCH] New dynamic_db database interface for BIND Return-Path: X-Original-To: bind-suggest@bugs.isc.org Date: Mon, 26 Mar 2012 16:42:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mx.pao1.isc.org To: Petr Spacek via RT From: Evan Hunt RT-Message-ID: Content-Length: 985 > We are still interested in contributing dynamic database API upstream. Thank you. > Please, can you provide more detailed requirements for contributing code? > > I would like to get information about: > - requirements to API tests Minimally, we'd like a system-level test (such as the ones in bind9/bin/tests/system). Those tests generally run one or more named servers listening on different loopback alias addresses, and exercise features of them at runtime. There are "dlz" and "dlzexternal" tests you might have a look at to get an idea. In the past few years we've also started introducing unit tests written using the NetBSD "ATF" testing framework. Those appear in bind9/lib/isc/tests and bind9/lib/dns/tests. > - requirements to documentation: Is enough to comment code in the same > way as BIND? API comments with doxygen directives such as BIND uses would be helpful. I would also suggest a README file for implementors, to be included with the sample driver.