CC: Pavel Simerda <psimerda@redhat.com>
MIME-Version: 1.0
In-Reply-To: <rt-3.8.6-32680-1379837262-286.34784-5-0@isc.org>
References: <RT-Ticket-34784@isc.org> <5231E416.1060401@redhat.com> <rt-3.8.6-32680-1379837262-286.34784-5-0@isc.org>
Message-ID: <523FFBB7.4030109@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Subject: Re: [ISC-Bugs #34784] more 'dhclient -6' instances steal each other packets
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
Date: Mon, 23 Sep 2013 10:28:39 +0200
To: dhcp-bugs@isc.org
Content-Transfer-Encoding: 7bit
From: Jiri Popelka <jpopelka@redhat.com>
RT-Message-ID: <rt-3.8.6-77135-1379924935-593.34784-0-0@isc.org>
Content-Length: 1452

First of all thank you for you reply !

On 09/22/2013 10:07 AM, Francis Dupont via RT wrote:
> On Thu Sep 12 15:56:23 2013, jpopelka@redhat.com wrote:
>
> => a simple question: is the problem for multicast or
> unicast packets (it should work for multicast packets
> but for unicast packets it has no chance to work with
> a single global socket bound to *.port)?

Unicast I think - I've seen it with Reply in response to Renew/Rebind 
and on other machine (kernel) with Advertise.

> => local_address* is for agents (i.e., relays and servers).
> In fact this part of the code is essentially for agents.
>
>> I don't know the internals, so the patch can be completely wrong
>> but up to now it's seemed to fix the problem and not cause any others.
>> I'll update it if I find something better.
>
> => I am afraid it will break agents via the multicast receive.

We already dropped it and have been using the following, i.e. binding to 
interface even for AF_INET6:

+++ dhcp-4.2.5/common/socket.c @@ -245,7 +245,7 @@ 
if_register_socket(struct interface_info

  #if defined(SO_BINDTODEVICE)
  	/* Bind this socket to this interface. */
-	if ((local_family != AF_INET6) && (info->ifp != NULL) &&
+	if (((do_multicast == 0)||(*do_multicast == 0)) && (info->ifp != NULL) &&
  	    setsockopt(sock, SOL_SOCKET, SO_BINDTODEVICE,
  			(char *)(info -> ifp), sizeof(*(info -> ifp))) < 0) {
  		log_fatal("setsockopt: SO_BINDTODEVICE: %m");


regards,
Jiri