Received: from mx.ams1.isc.org (mx.ams1.isc.org [199.6.1.65]) by bugs.isc.org (Postfix) with ESMTP id 19B922D20571 for ; Wed, 14 May 2014 19:55:03 +0000 (UTC) Received: from c-0500.emailmediator.com (c-0500.emailmediator.com [64.85.162.118]) by mx.ams1.isc.org (Postfix) with ESMTP id E23182383F0 for ; Wed, 14 May 2014 19:54:50 +0000 (UTC) (envelope-from reed@reedmedia.net) Received: from pool-71-170-213-71.dllstx.fios.verizon.net ([71.170.213.71] helo=reedmedia.net) by c-0500.emailmediator.com with esmtpa (Exim 4.69) (envelope-from ) id 1WkfGN-0004Az-0B for bind9-bugs@isc.org; Wed, 14 May 2014 15:54:51 -0400 Received: from reed@reedmedia.net by reedmedia.net with local (mailout 0.17) id 6725-1400097291; Wed, 14 May 2014 14:54:52 -0500 Delivered-To: bind9-bugs@bugs.isc.org MIME-Version: 1.0 User-Agent: Alpine 2.02 (NEB 1266 2009-07-14) Subject: json patch for statistics channel warning X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS autolearn=ham autolearn_force=no version=3.4.0 Return-Path: X-Original-To: bind9-bugs@bugs.isc.org Date: Wed, 14 May 2014 14:54:51 -0500 (CDT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.ams1.isc.org content-type: TEXT/PLAIN; charset="utf-8" Message-ID: To: bind9-bugs@isc.org X-X-Sender: reed@t1.m.reedmedia.net From: "Jeremy C. Reed" X-RT-Original-Encoding: US-ASCII Content-Length: 935 14-May-2014 19:48:16.642 statistics-channels specified but not effective due to missing XML library 14-May-2014 19:48:16.643 statistics channel listening on 127.0.0.1#8080 I am using: $ grep JSON ../../config.h #define HAVE_JSON 1 Okay to commit the following? +++ b/bin/named/statschannel.c @@ -2353,11 +2353,11 @@ ns_statschannels_configure(ns_server_t *server, const cfg_obj_t *config, * address-in-use error. */ if (statschannellist != NULL) { -#ifndef HAVE_LIBXML2 +#if !defined(HAVE_LIBXML2) && !defined(HAVE_JSON) isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL, NS_LOGMODULE_SERVER, ISC_LOG_WARNING, "statistics-channels specified but not effective " - "due to missing XML library"); + "due to missing XML or JSON library"); #endif Jeremy C. Reed ISC