MIME-Version: 1.0
In-Reply-To: <rt-3.8.6-2438-1409799309-964.37059-5-0@isc.org>
Content-Disposition: inline
References: <RT-Ticket-37059@isc.org> <20140903000601.GA9456@uow.edu.au> <rt-3.8.6-2438-1409799309-964.37059-5-0@isc.org>
Message-ID: <20140904040356.GA31116@uow.edu.au>
Content-Type: text/plain; charset="utf-8"
Subject: Re: [ISC-Bugs #37059] runtime error
Date: Thu, 4 Sep 2014 14:03:56 +1000
To: Mark Andrews via RT <bind9-bugs@isc.org>
From: "Peter D. Gray" <pdg@uow.edu.au>
RT-Message-ID: <rt-3.8.6-2416-1409803442-82.37059-0-0@isc.org>
Content-Length: 1272

On Thu, Sep 04, 2014 at 02:55:09AM +0000, Mark Andrews via RT wrote:
> This change should build
> 
> diff --git a/lib/isc/unix/socket.c b/lib/isc/unix/socket.c
> index 17012ed..b4c1c3f 100644
> --- a/lib/isc/unix/socket.c
> +++ b/lib/isc/unix/socket.c
> @@ -306,7 +306,11 @@ typedef isc_event_t intev_t;
>   * The size to raise the receive buffer to (from BIND 8).
>   */
>  #ifdef TUNE_LARGE
> +#ifdef sun
> +#define RCVBUFSIZE (1*1024*1024)
> +#else
>  #define RCVBUFSIZE (16*1024*1024)
> +#endif
>  #else
>  #define RCVBUFSIZE (32*1024)
>  #endif /* TUNE_LARGE */
> 

Yes, works no problems.

Have you considered changing all the places where you test for TUNE_LARGE
to something like

#define	RCVBUFSIZE (16*1024*1024*TUNEABLE_FACTOR)

and then putting something like

#ifdef	TUNE_LARGE
#define	TUNEABLE_FACTOR 8
#else
#define TUNEABLE_FACTOR 1
#endif

That way you get a consistant increase in buffer sizes across all buffers
and you can easily add additional tuneable settings in 1 place for
other sizes if you want (say you wanted a TUNE_MEDIUM setting).

Alternatively, you could make TUNEABLE_FACTOR a global variable
(yes I know) and set that at runtime and it would flow to all locations
where you want tuneable buffer sizes.

Just my 2c worth.

Regards,
pdg