Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1747

<div dir="ltr">Hi,all:<div><br></div><div>I possibly find a bug exist in isc_radix_search(lib/isc/radix.c), bind-9.10.1 .</div><div><br></div><div>Suppose we have two radix nodes a and b in a radix tree. Their prefix is <a href="http://3.3.3.0/24">3.3.3.0/24</a> and <a href="http://3.3.0.0/16.If">3.3.0.0/16.If</a> we call isc_radix_search with a isc_prefix_t set as <a href="http://3.3.3.3/22">3.3.3.3/22</a>, it will return success with node a. But for the definition of radix_tree it should be node b to be found.</div><div><br></div><div>The reason of this behavior hasn&#39;t been exposed is that isc_radix_search is called with a prefix set as x.x.x.x/32(Ipv4) for now.</div><div><br></div><div>Patch is as follows and it is suit for bind-9.10.1 :<br><div><div><br></div><div><div>diff --git i/lib/isc/radix.c w/lib/isc/radix.c</div><div>index df26615..6f9cc19 100644</div><div>--- i/lib/isc/radix.c</div><div>+++ w/lib/isc/radix.c</div><div>@@ -279,6 +279,9 @@ isc_radix_search(isc_radix_tree_t *radix, isc_radix_node_t **target,</div><div>        while (cnt-- &gt; 0) {</div><div>                node = stack[cnt];</div><div><br></div><div>+              if (prefix-&gt;bitlen &lt; node-&gt;bit){</div><div>+                   continue;</div><div>+              }</div><div>                if (_comp_with_mask(isc_prefix_tochar(node-&gt;prefix),</div><div>                                    isc_prefix_tochar(prefix),</div><div>                                    node-&gt;prefix-&gt;bitlen)) {</div></div><div><br></div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Best Regards.<br><div>Tom Sawyer.</div></div></div>
</div></div></div>