content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-RT-Original-Encoding: utf-8
Content-Length: 1146

Hi.

While backporting one fix into older RHEL I found
a suspicious IF statement in the new_adbentry() function
in lib/dns/adb.c. Note that this is from current master branch.

...
if (!adb->growentries_sent && adb->growentries_sent &&
	    adb->entriescnt > (adb->nentries * 8))
	{
...

The "!adb->growentries_sent && adb->growentries_sent" will
never be TRUE.

Based on the following code, the IF statement should be
...
if (!adb->growentries_sent &&
	    adb->entriescnt > (adb->nentries * 8))
	{
		isc_event_t *event = &adb->growentries;
		inc_adb_irefcnt(adb);
		isc_task_send(adb->task, &event);
		adb->growentries_sent = ISC_TRUE;
	}
...

The bug seems to be added by the following commit:

From c965b1869024ab38518fade703cc1dae2d71a59e Mon Sep 17 00:00:00 2001
From: Mark Andrews <marka@isc.org>
Date: Thu, 19 Jul 2012 23:00:21 +1000
Subject: [PATCH] 3353.   [bug]           Use a single task for task exclusive
 operations.                         [RT #29872]


Patch is attached.


Regards,
-- 
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience

PGP: 1D9F3C2D
Red Hat Inc.                               http://cz.redhat.com