Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) by bugs.isc.org (Postfix) with ESMTP id 19DBE71B586 for ; Wed, 18 Nov 2015 19:43:32 +0000 (UTC) Received: from chase.mycre.ws (chase.mycre.ws [70.89.251.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "chase.mycre.ws", Issuer "mycre.ws" (not verified)) by mx.pao1.isc.org (Postfix) with ESMTPS id A690F3493C9 for ; Wed, 18 Nov 2015 19:43:30 +0000 (UTC) Received: by chase.mycre.ws (Postfix, from userid 1000) id 178961C42EFC; Wed, 18 Nov 2015 14:43:29 -0500 (EST) From edmonds@debian.org Wed Nov 18 19:43:32 2015 Delivered-To: bind9-bugs@bugs.isc.org MIME-Version: 1.0 Subject: json-c >= 0.11 required by BIND 9.10.3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Return-Path: X-Original-To: bind9-bugs@bugs.isc.org Content-Disposition: inline Date: Wed, 18 Nov 2015 14:43:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org content-type: text/plain; charset="utf-8" Message-ID: <20151118194329.GA18352@mycre.ws> To: bind9-bugs@isc.org From: "Robert Edmonds" X-RT-Original-Encoding: ascii X-RT-Interface: Email Content-Length: 1475 Hi, This change was implemented in BIND 9.10.3: 4073. [cleanup] Add libjson-c version number reporting to "named -V"; normalize version number formatting. [RT #38056] The corresponding commit is 8262b7708, which adds unconditional references to the JSON_C_VERSION macro and json_c_version() function exposed by the json-c library. However, these identifiers were added relatively recently (apparently, they appeared in json-c version 0.11, released 2013), and are missing in previous versions, which are still somewhat common. E.g., the current stable version of Debian offers json-c 0.11, while the previous stable version of Debian only offers json-c 0.10. Unless there's some technical requirement for requiring json-c >= 0.11 (and I suspect there isn't, otherwise I'd expect the minimum version requirement to be mentioned in the docs), I would suggest making the relevant printf's dependent on both HAVE_JSON and JSON_C_VERSION being defined, rather than only on HAVE_JSON, e.g.: #if (defined(HAVE_JSON) && defined(JSON_C_VERSION)) printf("compiled with libjson-c version: %s\n", JSON_C_VERSION); printf("linked to libjson-c version: %s\n", json_c_version()); #endif (It looks like json-c introduced both the macro and the function at the same time.) Thanks! -- Robert Edmonds edmonds@debian.org