From marka@isc.org Wed Nov 18 20:22:14 2015 In-Reply-To: Your message of "Wed, 18 Nov 2015 19:43:33 -0000." X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 X-RT-Interface: API References: <20151118194329.GA18352@mycre.ws> content-type: text/plain; charset="utf-8" Message-ID: <20151118202212.5DE623D07136@rock.dv.isc.org> X-RT-Original-Encoding: utf-8 Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) by bugs.isc.org (Postfix) with ESMTP id 240B971B586 for ; Wed, 18 Nov 2015 20:22:14 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx.pao1.isc.org (Postfix) with ESMTPS id 402013493C9 for ; Wed, 18 Nov 2015 20:22:12 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id EE59D16004E for ; Wed, 18 Nov 2015 20:23:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id E0EDB160086 for ; Wed, 18 Nov 2015 20:23:10 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CwHaavCZVGNS for ; Wed, 18 Nov 2015 20:23:10 +0000 (UTC) Received: from rock.dv.isc.org (c122-106-161-187.carlnfd1.nsw.optusnet.com.au [122.106.161.187]) by zmx1.isc.org (Postfix) with ESMTPSA id 9E34816004E for ; Wed, 18 Nov 2015 20:23:10 +0000 (UTC) Received: from rock.dv.isc.org (localhost [IPv6:::1]) by rock.dv.isc.org (Postfix) with ESMTP id 5DE623D07136 for ; Thu, 19 Nov 2015 07:22:12 +1100 (EST) Delivered-To: bind9-bugs@bugs.isc.org Subject: Re: [ISC-Bugs #41147] json-c >= 0.11 required by BIND 9.10.3 Return-Path: X-Original-To: bind9-bugs@bugs.isc.org Date: Thu, 19 Nov 2015 07:22:12 +1100 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org To: bind9-bugs@isc.org From: "Mark Andrews" RT-Message-ID: Content-Length: 2243 Thanks. Already fixed in next version. In message , "Robert Edmonds via RT" writes: > > Wed Nov 18 19:43:32 2015: Request 41147 was acted upon. > Transaction: Ticket created by edmonds@debian.org > Queue: bind9 > Subject: json-c >= 0.11 required by BIND 9.10.3 > Owner: Nobody > Requestors: edmonds@debian.org > Status: new > Ticket > ----------------------------------------------------------------------- > > Hi, > > This change was implemented in BIND 9.10.3: > > 4073. [cleanup] Add libjson-c version number reporting to > "named -V"; normalize version number formatting. > [RT #38056] > > The corresponding commit is 8262b7708, which adds unconditional > references to the JSON_C_VERSION macro and json_c_version() function > exposed by the json-c library. However, these identifiers were added > relatively recently (apparently, they appeared in json-c version 0.11, > released 2013), and are missing in previous versions, which are still > somewhat common. E.g., the current stable version of Debian offers > json-c 0.11, while the previous stable version of Debian only offers > json-c 0.10. > > Unless there's some technical requirement for requiring json-c >= 0.11 > (and I suspect there isn't, otherwise I'd expect the minimum version > requirement to be mentioned in the docs), I would suggest making the > relevant printf's dependent on both HAVE_JSON and JSON_C_VERSION being > defined, rather than only on HAVE_JSON, e.g.: > > #if (defined(HAVE_JSON) && defined(JSON_C_VERSION)) > printf("compiled with libjson-c version: %s\n", > JSON_C_VERSION); > printf("linked to libjson-c version: %s\n", > json_c_version()); > #endif > > (It looks like json-c introduced both the macro and the function at the > same time.) > > Thanks! > > -- > Robert Edmonds > edmonds@debian.org > > -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org