From pspacek@redhat.com Wed Feb 17 13:28:27 2016 X-Scanned-BY: MIMEDefang 2.68 on 10.5.11.24 MIME-Version: 1.0 In-Reply-To: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 X-RT-Interface: API References: <56C321F1.3080905@redhat.com> <20160216180151.GB89140@isc.org> Message-ID: <56C47574.5040601@redhat.com> content-type: text/plain; charset="utf-8" Organization: Red Hat X-RT-Original-Encoding: utf-8 Received: from mx.ams1.isc.org (mx.ams1.isc.org [IPv6:2001:500:60::65]) by bugs.isc.org (Postfix) with ESMTP id 83BE671B5A8 for ; Wed, 17 Feb 2016 13:28:27 +0000 (UTC) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx.ams1.isc.org (Postfix) with ESMTPS id 6A4201FCB6B for ; Wed, 17 Feb 2016 13:28:25 +0000 (UTC) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 7E2B31E28 for ; Wed, 17 Feb 2016 13:28:23 +0000 (UTC) Received: from pspacek.brq.redhat.com (ovpn-204-69.brq.redhat.com [10.40.204.69]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1HDSLjH002987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 17 Feb 2016 08:28:23 -0500 Delivered-To: bind9-bugs@bugs.isc.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 Subject: Re: [ISC-Bugs #41707] Recent change "improve performance of RBT (#41165)" magically broke dyndb Return-Path: X-Original-To: bind9-bugs@bugs.isc.org Date: Wed, 17 Feb 2016 14:28:20 +0100 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.ams1.isc.org To: bind9-bugs@isc.org Content-Transfer-Encoding: 7bit From: "Petr Spacek" RT-Message-ID: Content-Length: 1236 On 16.2.2016 19:01, Evan Hunt via RT wrote: >> I just found out that dyndb tests (git/bin/tests/system/dyndb) are failing on >> latest master. git bisect pointed me to following change: > > Yep, thanks, we just discovered the same problem here last week. > > It's the same class of problem we had back while we were developing > it: inconsistent namespace resolution for global variables referenced > inside the dyndb driver. It all works fine on ubuntu, but it's failing > on your system (which I guess is redhat?), and also on BSD. > > We fixed it in the original dyndb work by passing a pointer to named's > hash context (isc_hashctx) to the dyndb driver, so that hashes would be > consistent. But the new hash function introduced a while ago deprecates > the hash context, and so hashes started coming out differently inside and > outside of the driver, causing RBT lookups to fail. A fix is attached, > can you try it? It works for me on Fedora 23. Thank you for your help! > I'm also looking into an intermittent reference leak that seems to > happen sometimes when a dyndb driver is reloaded. That one's making > slower progress. How do you detect the leak? I can try and have a look, too. -- Petr Spacek @ Red Hat