From pspacek@redhat.com Thu Aug 18 11:23:48 2016 X-Scanned-BY: MIMEDefang 2.68 on 10.5.11.22 CC: "Evan Hunt" MIME-Version: 1.0 In-Reply-To: X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 X-RT-Interface: API References: Message-ID: <788ba4fd-9fd2-abf0-8512-3539bc9320ab@redhat.com> content-type: text/plain; charset="utf-8" Organization: Red Hat X-RT-Original-Encoding: utf-8 Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) by bugs.isc.org (Postfix) with ESMTP id 3A12D71B5A8 for ; Thu, 18 Aug 2016 11:23:48 +0000 (UTC) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 8CA6E3493DE; Thu, 18 Aug 2016 11:23:46 +0000 (UTC) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FEC34E33C; Thu, 18 Aug 2016 11:23:45 +0000 (UTC) Received: from pspacek.brq.redhat.com (pspacek.brq.redhat.com [10.34.128.7]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7IBNh4L022751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Aug 2016 07:23:45 -0400 Delivered-To: bind9-review@bugs.isc.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Subject: Re: [ISC-Bugs #43050] pre-release DynDB nits Return-Path: X-Original-To: bind9-review@bugs.isc.org Date: Thu, 18 Aug 2016 13:23:43 +0200 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 18 Aug 2016 11:23:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org To: bind9-review@isc.org Content-Transfer-Encoding: 7bit From: "Petr Spacek" RT-Message-ID: Content-Length: 933 On 17.8.2016 20:41, Evan Hunt via RT wrote: > 4445. [cleanup] isc_errno_toresult() can now be used to call the > formerly private function isc__errno2result(). > [RT #43050] > > 9.11.0, 9.9.10, 9.10.5 > > 4444. [bug] Fixed some issues related to dyndb: A bug caused > braces to be omitted when passing configuration text > from named.conf to a dyndb driver, and there was a > use-after-free in the sample dyndb driver. [RT #43050] > > 9.11.0 > > Petr, you should be able to pull this code from our public source repository > (source.isc.org) as soon as it syncs. Or I can send you a patch if you prefer. I fetched 3390d74e33385337631b19e68760025e0ca5d6ec from Git and confirm that it fixes the problem in parser. The new header isc/errno.h works fine if I install it manually. It does not get installed using 'make install' - I think that this deserves one more patch. Thank you! -- Petr Spacek @ Red Hat