From pspacek@redhat.com Wed Aug 31 10:33:39 2016 X-Scanned-BY: MIMEDefang 2.68 on 10.5.11.23 MIME-Version: 1.0 In-Reply-To: X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 X-RT-Interface: API References: <20160830184754.GA26740@isc.org> Message-ID: content-type: text/plain; charset="utf-8" Organization: Red Hat X-RT-Original-Encoding: utf-8 Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) by bugs.isc.org (Postfix) with ESMTP id A464671B5A8 for ; Wed, 31 Aug 2016 10:33:38 +0000 (UTC) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id DBA68349502 for ; Wed, 31 Aug 2016 10:33:36 +0000 (UTC) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D21A93B70C for ; Wed, 31 Aug 2016 10:33:35 +0000 (UTC) Received: from pspacek.brq.redhat.com (pspacek.brq.redhat.com [10.34.128.7]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7VAXXJF009068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 31 Aug 2016 06:33:35 -0400 Delivered-To: bind9-review@bugs.isc.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Subject: Re: [ISC-Bugs #43050] pre-release DynDB nits Return-Path: X-Original-To: bind9-review@bugs.isc.org Date: Wed, 31 Aug 2016 12:33:33 +0200 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 31 Aug 2016 10:33:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org To: bind9-review@isc.org Content-Transfer-Encoding: 7bit From: "Petr Spacek" RT-Message-ID: Content-Length: 914 On 30.8.2016 20:47, Evan Hunt via RT wrote: >> For some reason it does not work and I'm not sure if it is caused by >> mistake I made or what is going on. I'm attaching minimal program to >> reproduce the crash. > > My fault, I left a piece out, darn it. I forgot that cfg_parse_buffer() > calls isc_lex_openbuffer() too. We need to be able to have it skip that > step, so you can open the buffer and set things up before you start > parsing. > > I'm afraid this bug is going to persist into 9.11.0, but it can be fixed in > 9.11.1, and I'll be able to give you a patch for it in the meantime. I'm fine with it as long as dyndb_init() does not change. (I do not see reason for such change, just saying.) > As a temporary measure you can also kluge around it at the driver level > by yanking some code out of libisccfg and having a local buffer parser. > See attached. Thank you! -- Petr Spacek @ Red Hat