From jay-ford@uiowa.edu Mon Sep 12 17:30:20 2016 MIME-Version: 1.0 In-Reply-To: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 X-RT-Interface: API References: Reply-To: "Jay Ford" Message-ID: content-type: text/plain; charset="utf-8"; format="flowed" X-X-Sender: jnford@headset.its.uiowa.edu X-RT-Original-Encoding: utf-8 Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) by bugs.isc.org (Postfix) with ESMTP id 0460871B5A8 for ; Mon, 12 Sep 2016 17:30:20 +0000 (UTC) Received: from headset.its.uiowa.edu (headset.its.uiowa.edu [IPv6:2620:0:e50:1::123]) by mx.pao1.isc.org (Postfix) with ESMTP id 4C3AB3493DF for ; Mon, 12 Sep 2016 17:30:18 +0000 (UTC) Received: from localhost (localhost [IPv6:::1]) by headset.its.uiowa.edu (Postfix) with ESMTPS id D4E09DF9BB for ; Mon, 12 Sep 2016 12:30:16 -0500 (CDT) Delivered-To: dhcp-bugs@bugs.isc.org User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Subject: Re: [ISC-Bugs #43185] dhcpd crashes on truncated lease file if lease-id-format hex Return-Path: X-Original-To: dhcp-bugs@bugs.isc.org Date: Mon, 12 Sep 2016 12:30:16 -0500 (CDT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org To: "Thomas Markwalder via RT" From: "Jay Ford" RT-Message-ID: Content-Length: 816 On Mon, 12 Sep 2016, Thomas Markwalder via RT wrote: > I found your problem and have attached a patch to fix it. There's a bug in > the hex output code which short changes the allocated buffer size by 1. > Sort of surprising that it doesn't fallover more often. > > I've attached the patch for you to try out. This will be in 4.3.5 and > 4.1-ESV-R14 finals due out at the end of this month. > > Let me know if this fixes the issue for you. I'll probably wait for 4.3.5 given that's already in beta. We can live without the hex lease until then. Thanks for the quick response. ________________________________________________________________________ Jay Ford, Network Engineering Group, Information Technology Services University of Iowa, Iowa City, IA 52242 email: jay-ford@uiowa.edu, phone: 319-335-5555