List-Archive:
MIME-Version: 1.0
List-Post:
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE autolearn=unavailable autolearn_force=no version=3.4.0
In-Reply-To:
Errors-To: bind-workers-bounces@isc.org
List-Help:
X-Cam-Antivirus: no malware found
X-Mailman-Version: 2.1.20
References:
content-type: text/plain; charset="utf-8"
Message-ID:
Received: from rock.dv.isc.org (localhost [IPv6:::1]) by rock.dv.isc.org (Postfix) with ESMTP id 1B482602D755 for ; Tue, 24 Jan 2017 06:59:09 +1100 (EST)
Received: from zimbra.isc.org [149.20.0.17] by rock.dv.isc.org with IMAP (fetchmail-6.3.22) for (single-drop); Tue, 24 Jan 2017 06:59:09 +1100 (EST)
Received: from zmx1.isc.org (LHLO zmx1.isc.org) (149.20.0.20) by zmail1.isc.org with LMTP; Mon, 23 Jan 2017 19:57:54 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 26E9816006D for ; Mon, 23 Jan 2017 19:57:54 +0000 (UTC)
Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uAI562woNca9 for ; Mon, 23 Jan 2017 19:57:54 +0000 (UTC)
Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) by zmx1.isc.org (Postfix) with ESMTPS id 12E01160052 for ; Mon, 23 Jan 2017 19:57:54 +0000 (UTC)
Received: from lists.isc.org (lists.isc.org [149.20.1.60]) by mx.pao1.isc.org (Postfix) with ESMTP id 92ACE3495B8 for ; Mon, 23 Jan 2017 19:57:51 +0000 (UTC)
Received: from lists.isc.org (localhost [127.0.0.1]) by lists.isc.org (Postfix) with ESMTP id 4EFCC67EE4E; Mon, 23 Jan 2017 19:57:48 +0000 (UTC)
Received: from mx.ams1.isc.org (mx.ams1.isc.org [199.6.1.65]) by lists.isc.org (Postfix) with ESMTP id AB16267EE5A for ; Mon, 23 Jan 2017 19:57:46 +0000 (UTC)
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143]) by mx.ams1.isc.org (Postfix) with ESMTP id 9A5221FCC6A for ; Mon, 23 Jan 2017 19:57:44 +0000 (UTC)
Received: from grey.csi.cam.ac.uk ([131.111.57.57]:53135) by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25) with esmtps (TLSv1:ECDHE-RSA-AES256-SHA:256) id 1cVkkK-0001Gr-oC (Exim 4.88) for bind-workers@lists.isc.org (return-path ); Mon, 23 Jan 2017 19:57:44 +0000
Delivered-To: marka@localhost.dv.isc.org
Delivered-To: bind-workers@lists.isc.org
Subject: Re: ISC_MEM_TRACKLINES is accidentally quadratic, was Re: support for large batch jobs with mdig
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
Return-Path:
X-Original-To: marka@localhost
X-Original-To: bind-workers@lists.isc.org
List-Subscribe: ,
Sender: "bind-workers"
Date: Mon, 23 Jan 2017 19:57:44 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org
Precedence: list
X-Beenthere: bind-workers@lists.isc.org
List-ID: BIND Workers Mailing List
To: bind-workers@isc.org
Content-Transfer-Encoding: 7bit
List-Unsubscribe: ,
X-Cam-Scannerinfo: http://help.uis.cam.ac.uk/email-scanner-virus
From: "Tony Finch"
X-RT-Original-Encoding: ascii
Content-Length: 996
Tony Finch wrote:
>
> This accidentally quadratic performance is to do with ISC_MEM_TRACKLINES -
> turn that off and freeing is instant! But it needs a fix...
The other fix is to remove what looks (from the weird indentation) like
some stray debugging code that got committed by accident.
And with mdig unhobbled, it manages to process the whole top-1m list in
less than 34s, nearly 30kqps. Not bad!
---
bin/tools/mdig.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/bin/tools/mdig.c b/bin/tools/mdig.c
index 034bf91..0839845 100644
--- a/bin/tools/mdig.c
+++ b/bin/tools/mdig.c
@@ -1901,7 +1901,6 @@ main(int argc, char *argv[]) {
fatal("could not find either IPv4 or IPv6");
mctx = NULL;
-isc_mem_debugging = ISC_MEM_DEBUGRECORD;
RUNCHECK(isc_mem_create(0, 0, &mctx));
lctx = NULL;
--
2.10.1.445.g3cdd5d1
_______________________________________________
bind-workers mailing list
bind-workers@lists.isc.org
https://lists.isc.org/mailman/listinfo/bind-workers