From www@isc.org Mon Feb 13 13:41:00 2017 MIME-Version: 1.0 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 X-Mailer: PHPMailer 5.2.22 (https://github.com/PHPMailer/PHPMailer) content-type: text/plain; charset="utf-8" Message-ID: Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) by bugs.isc.org (Postfix) with ESMTP id 4D3A071B5A8 for ; Mon, 13 Feb 2017 13:41:00 +0000 (UTC) Received: from iscwebprod.isc.org (iscwebprod.isc.org [IPv6:2001:4f8:1:d::16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 21078349422 for ; Mon, 13 Feb 2017 13:40:58 +0000 (UTC) Received: from www (uid 80) (envelope-from www@iscwebprod.isc.org) id 7b7d0b by iscwebprod.isc.org (DragonFly Mail Agent v0.11); Mon, 13 Feb 2017 13:40:57 +0000 Delivered-To: bind9-bugs@bugs.isc.org Subject: DiG 9.12.0-pre-alpha - Dig INSIST on multiple +client= options Return-Path: X-Original-To: bind9-bugs@bugs.isc.org Date: Mon, 13 Feb 2017 13:40:57 +0000 X-Wpcf7-Content-Type: text/plain X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org X-PHP-Originating-Script: 20001:class-phpmailer.php To: bind-bugs@isc.org From: "Yuri Schaeffer" X-RT-Original-Encoding: utf-8 X-RT-Interface: Email Content-Length: 1089 Bug Report from www.isc.org: Name: Yuri Schaeffer Email: yuri@nlnetlabs.nl Software Version: DiG 9.12.0-pre-alpha OS: Linux Subject:Dig INSIST on multiple +client= options Bug Detail =========== When providing multiple +client options to dig, dig will assert when cleaning up memory: $ dig +client=0/0 +client=0/0 A possible patch on top of git/master, to reject 2nd client option: index 28f7eda59f..40a28f83bd 100644 --- a/bin/dig/dighost.c +++ b/bin/dig/dighost.c @@ -1096,6 +1096,9 @@ parse_netprefix(isc_sockaddr_t **sap, const char *value) { isc_boolean_t prefix_parsed = ISC_FALSE; char buf[sizeof("xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:XXX.XXX.XXX.XXX/128")]; + if (*sap != NULL) + return ISC_R_FAILURE; + if (strlcpy(buf, value, sizeof(buf)) >= sizeof(buf)) fatal("invalid prefix '%s'\n", value); Regards, Yuri --- This email was received through isc.org Bug Submission Form