MIME-Version: 1.0 In-Reply-To: X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Disposition: inline X-RT-Interface: Web References: <317307465.487433.1489162746275.JavaMail.zimbra@redhat.com> <960257277.509834.1489165546786.JavaMail.zimbra@redhat.com> <20170310174641.GB92236@isc.org> <1dee09e0-c1a7-3d7f-0c71-9368e04ae1be@redhat.com> Content-Type: text/plain; charset="utf-8" Message-ID: Content-Transfer-Encoding: binary X-RT-Original-Encoding: utf-8 RT-Send-CC: X-RT-Encrypt: 0 X-RT-Sign: 0 Content-Length: 890 I've reviewed your patch, and made a few changes: - reverted the changes to dns_view_addnewzones(), put the allow code back into view.c. - moved your file_sanitize_legacy() function into view.c as nz_legacy() - made new-zones-directory a view option instead of options-only - added a dns_view_setnewzonedir() function. That's now used by nz_legacy() to find the right place to put the files - added documentation of new-zones-directory - noticed that the existing documentation of NZD and NZF files was rather poor, so expanded them - fixed the test to check for NZD instead of NZF when linked with LMDB (I want to thank you for writing a test, that was particularly helpful.) Since I changed your code a fair bit I'm going to ask one of my colleagues to review it too, but I expect this will be merged to our master branch (for 9.12.0) soon. Thank you again for the contribution.