MIME-Version: 1.0 In-Reply-To: X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Disposition: inline X-RT-Interface: Web References: Content-Type: text/plain; charset="utf-8" Message-ID: Content-Transfer-Encoding: binary X-RT-Original-Encoding: utf-8 RT-Send-CC: X-RT-Encrypt: 0 X-RT-Sign: 0 Content-Length: 1616 On Wed Apr 12 15:07:36 2017, fdupont wrote: > The EUI 64 idea was good 10 years ago but > not today when privacy concerns became > important... Now it is a customer request. > BTW should we port this to Kea? > That's a question for Kea dev probably. In theory it wouldn't be hard to do as Kea has an alternative allocation algorithm method mechanism, but we currently only support one algorithm (incremental). It would take a bit more work in configuration sanity checking and such. > Perhaps pin6_addr should take a pointer > (note the copied structure is on 128 bits > so the difference is not so great). > Agreed, changed it. I did it as a non-pointer initially to keep it "symmetrical" with piaddr() but that's a pretty weak argument. > Fixed a spelling error in dhcpd.conf.5 > > A question is "computed" better than "calculated" > (I got the same in a Kea review)? > They are essentially synonyms, I think either one is perfectly acceptable. > Possible missing "are" in: > "though they "outside" the subnet" > (dhcpd.conf.5) > Fixed. > Another spelling error in dhcpv6.c, > did some re-indents & co too. > > Put the star on the pointer variable side, > not on the pointer type side. > There should be a blank line between > declarations and statements, and > declarations must be first. > Fixed mdb6.c (BTW the last point > is not style, just old C standard). > > Tabulation uses was not consistent > so I tabilfied .c files. > > I noticed inconsistent use of > signed/unsigned (e.g a counter > declared as an int) but I didn't > fix them as ISC DHCP is already > full of such things...