From dot@dotat.at Fri Jun 16 16:52:02 2017 CC: "Tony Finch" MIME-Version: 1.0 In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 X-RT-Interface: API X-Cam-Antivirus: no malware found References: Message-ID: content-type: TEXT/PLAIN; charset="utf-8" X-RT-Original-Encoding: utf-8 Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) by bugs.isc.org (Postfix) with ESMTP id 2038971B5A9 for ; Fri, 16 Jun 2017 16:52:02 +0000 (UTC) Received: from ppsw-30.csi.cam.ac.uk (ppsw-30.csi.cam.ac.uk [131.111.8.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 7967B3493BB for ; Fri, 16 Jun 2017 16:51:59 +0000 (UTC) Received: from grey.csi.cam.ac.uk ([131.111.57.57]:45191) by ppsw-30.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25) with esmtps (TLSv1:ECDHE-RSA-AES256-SHA:256) id 1dLuTU-000iOm-fO (Exim 4.89) (return-path ); Fri, 16 Jun 2017 17:51:56 +0100 Delivered-To: bind9-bugs@bugs.isc.org User-Agent: Alpine 2.11 (DEB 23 2013-08-11) Subject: Re: [ISC-Bugs #45388] [PATCH] nsec3hash: compatibility with salt "-" Return-Path: X-Original-To: bind9-bugs@bugs.isc.org Date: Fri, 16 Jun 2017 17:51:55 +0100 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org To: "Mark Andrews via RT" X-Cam-Scannerinfo: http://help.uis.cam.ac.uk/email-scanner-virus From: "Tony Finch" RT-Message-ID: Content-Length: 865 Thanks! And nice const-correctness :-) There are a couple of missing const qualifiers - see below. Tony. -- f.anthony.n.finch http://dotat.at/ - I xn--zr8h punycode Humber, Thames, Dover: West 4 or 5, becoming variable 3 or 4 later. Slight, occasionally moderate at first in Humber. Fair. Good, occasionally moderate later. diff --git a/bin/tools/nsec3hash.c b/bin/tools/nsec3hash.c index 93bfbab..a1c40f5 100644 --- a/bin/tools/nsec3hash.c +++ b/bin/tools/nsec3hash.c @@ -70,7 +70,7 @@ typedef void nsec3printer(unsigned algo, unsigned flags, unsigned iters, const char *digest); static void -nsec3hash(nsec3printer *nsec3print, char *algostr, char *flagstr, +nsec3hash(nsec3printer *nsec3print, const char *algostr, const char *flagstr, const char *iterstr, const char *saltstr, const char *domain) { dns_fixedname_t fixed;