Message-ID: Subject: rrchecker system test improperly handles some failures Date: Mon, 24 Jul 2017 09:04:21 +0000 To: bind9-public@isc.org X-RT-Interface: Web Content-Transfer-Encoding: binary MIME-Version: 1.0 From: michal@isc.org X-Mailer: MIME-tools 5.508 (Entity 5.508) Content-Type: text/plain; charset="utf-8" Content-Disposition: inline X-RT-Original-Encoding: utf-8 Content-Length: 579 Most contemporary shells execute each command of a multi-command pipeline in a subshell environment. Environment variables set inside a subshell do not affect the parent shell's environment. Meanwhile, the rrchecker system test sets the ret variable inside a while loop which is the last command in a pipeline. Thus, while error messages will be printed out when named-rrchecker encounters a problem, these problems will not affect the result of the system test. This issue seems to be have been present in the code ever since named-rrchecker was added by commit 49c1e0d18d.