X-Original-To: bind9-public@bugs.isc.org Message-ID: <20170724090846.2498D7F79966@rock.dv.isc.org> X-RT-Interface: Email X-RT-Original-Encoding: utf-8 In-Reply-To: Your message of "Mon, 24 Jul 2017 09:04:23 +0000." Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 46504D78A91 for ; Mon, 24 Jul 2017 09:08:51 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 43E1A349314 for ; Mon, 24 Jul 2017 09:08:49 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id 318D8160054 for ; Mon, 24 Jul 2017 09:08:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 2251416004A for ; Mon, 24 Jul 2017 09:08:49 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id im8zjW0pLv2x for ; Mon, 24 Jul 2017 09:08:49 +0000 (UTC) Received: from rock.dv.isc.org (c27-253-115-14.carlnfd2.nsw.optusnet.com.au [27.253.115.14]) by zmx1.isc.org (Postfix) with ESMTPSA id CB711160041 for ; Mon, 24 Jul 2017 09:08:48 +0000 (UTC) Received: from rock.dv.isc.org (localhost [IPv6:::1]) by rock.dv.isc.org (Postfix) with ESMTP id 2498D7F79966 for ; Mon, 24 Jul 2017 19:08:46 +1000 (AEST) X-RT-Incoming-Encryption: Not encrypted X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org References: Return-Path: content-type: text/plain; charset="utf-8" To: bind9-public@isc.org From: "Mark Andrews" From marka@isc.org Mon Jul 24 09:08:51 2017 Delivered-To: bind9-public@bugs.isc.org Date: Mon, 24 Jul 2017 19:08:46 +1000 Subject: Re: [ISC-Bugs #45602] rrchecker system test improperly handles some failures X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 RT-Message-ID: Content-Length: 939 In message , "Michal Kepien via RT" writes: > Most contemporary shells execute each command of a multi-command > pipeline in a subshell environment. Environment variables set inside a > subshell do not affect the parent shell's environment. Meanwhile, the > rrchecker system test sets the ret variable inside a while loop which is > the last command in a pipeline. Thus, while error messages will be > printed out when named-rrchecker encounters a problem, these problems > will not affect the result of the system test. The shell is broken if { } fails to update the variable. If ( ) was being used then you would have a point. > This issue seems to be have been present in the code ever since > named-rrchecker was added by commit 49c1e0d18d. -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org