X-RT-Original-Encoding: utf-8 MIME-Version: 1.0 X-RT-Interface: Web Content-Transfer-Encoding: binary X-Mailer: MIME-tools 5.508 (Entity 5.508) Message-ID: Content-Disposition: inline Content-Type: text/plain; charset="utf-8" In-Reply-To: References: Content-Length: 915 Refactoring was done in the rt45610 branch. Changes introduced: - conversions to/from type-specific structures were previously performed only as part of wire data processing tests for selected RR types; these conversions are now performed for all correctly processed input RDATA, both in text and wire form, - error_callback() and warn_callback() looked like placeholders; as dns_rdata_fromtext() accepts NULL for its callbacks parameters, I removed these two functions from rdata_test.c, - text RDATA tests used to initialize the source buffer using isc_buffer_init(); initialization is now rather performed using isc_buffer_constinit(), in order to enable constifying passed arrays of input data. With these cleanups in place, adding tests for a new RR type should boil down to defining test RDATA in text and/or wire form and calling a single function. Please review.