To: "Michal Kepien via RT" CC: MIME-Version: 1.0 Received: from bikeshed.isc.org (bikeshed.isc.org [149.20.48.19]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mail.isc.org", Issuer "RapidSSL CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id DE797D78ABE for ; Tue, 25 Jul 2017 19:30:22 +0000 (UTC) Received: by bikeshed.isc.org (Postfix, from userid 10292) id A7590216C1E; Tue, 25 Jul 2017 19:30:22 +0000 (UTC) X-RT-Interface: Email Message-ID: <20170725193022.GA49597@isc.org> content-type: text/plain; charset="utf-8" From: "Evan Hunt" Subject: Re: [ISC-Bugs #45610] Refactor lib/dns/tests/rdata_test.c User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Original-To: bind9-public@bugs.isc.org Delivered-To: bind9-public@bugs.isc.org X-RT-Original-Encoding: utf-8 X-RT-Incoming-Encryption: Not encrypted From each@isc.org Tue Jul 25 19:30:23 2017 Content-Disposition: inline In-Reply-To: Date: Tue, 25 Jul 2017 19:30:22 +0000 References: RT-Message-ID: Content-Length: 561 On Tue, Jul 25, 2017 at 11:06:42AM +0000, Michal Kepien via RT wrote: > With these cleanups in place, adding tests for a new RR type should boil > down to defining test RDATA in text and/or wire form and calling a > single function. This is good. While you're in there, would you mind looking over bin/tests/rdata_test.c (an obsolete test from before we used ATF), and see whether there's anything useful in there that we can move to lib/dns/tests/rdata_test.c? If so, let's move the code over, then remove the file, and if not, let's just remove the file.