X-Mailer: MIME-tools 5.508 (Entity 5.508) In-Reply-To: References: X-RT-Interface: Web Content-Disposition: inline MIME-Version: 1.0 X-RT-Original-Encoding: utf-8 Message-ID: Content-Transfer-Encoding: binary Content-Type: text/plain; charset="utf-8" RT-Send-CC: Content-Length: 456 My only suggestion is that data_to_hex() looks pretty generically useful, so I'd put it into dnstest.c, and pass in a static buffer when calling instead of using isc_mem_allocate(). I pushed that change to the branch, if you're okay with it then I think this is fine to commit. (Note, I only evaluated the code, I haven't checked the test case data to confirm that it tests what it says it does. I take it that's unchanged from previous versions though.)