Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id A8E49D78AF1 for <bind9-public@bugs.isc.org>; Tue,  1 Aug 2017 08:10:00 +0000 (UTC)
Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id C65B534A550 for <bind9-public@isc.org>; Tue,  1 Aug 2017 08:10:05 +0000 (UTC)
Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id AE248160041 for <bind9-public@isc.org>; Tue,  1 Aug 2017 08:10:05 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 98E8E16004F for <bind9-public@isc.org>; Tue,  1 Aug 2017 08:10:05 +0000 (UTC)
Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mUGrgA2zFnt7 for <bind9-public@isc.org>; Tue,  1 Aug 2017 08:10:05 +0000 (UTC)
Received: from rays-mbp.local (unknown [46.227.151.81]) by zmx1.isc.org (Postfix) with ESMTPSA id 38136160041 for <bind9-public@isc.org>; Tue,  1 Aug 2017 08:10:05 +0000 (UTC)
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
From: "Ray Bellis" <ray@isc.org>
Subject: Re: [ISC-Bugs #45664] isc_time_formattimestamp and friends are not thread safe.
MIME-Version: 1.0
References: <RT-Ticket-45664@isc.org> <rt-4.4.1-15228-1501574543-163.45664-3-0@isc.org>
X-RT-Interface: Email
Return-Path: <ray@isc.org>
X-RT-Original-Encoding: utf-8
In-Reply-To: <rt-4.4.1-15228-1501574543-163.45664-3-0@isc.org>
To: bind9-public@isc.org
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0
content-type: text/plain; charset="utf-8"
X-Original-To: bind9-public@bugs.isc.org
Message-ID: <94b367d3-f6f1-f3e5-c896-29584c067d30@isc.org>
X-RT-Incoming-Encryption: Not encrypted
Date: Tue, 1 Aug 2017 09:10:05 +0100
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org
From ray@isc.org  Tue Aug  1 08:10:01 2017
Content-Language: en-US
Delivered-To: bind9-public@bugs.isc.org
Content-Transfer-Encoding: 7bit
RT-Message-ID: <rt-4.4.1-32630-1501575002-1001.45664-0-0@isc.org>
Content-Length: 332

On 01/08/2017 09:02, Mark Andrews via RT wrote:

> isc_time_formattimestamp calls localtime rather than localtime_r when threaded.
> there are similar issues for gmtime vs gmtime_r.

While this is being looked at, I noticed that all three possible time
strings are generated for every log entry even though only one will be used.