X-Mailer: MIME-tools 5.508 (Entity 5.508) MIME-Version: 1.0 Content-Disposition: inline References: <20170802031131.GA63960@isc.org> <20170802211456.GD72046@isc.org> Message-ID: X-RT-Interface: Web In-Reply-To: X-RT-Original-Encoding: utf-8 Content-Transfer-Encoding: binary Content-Type: text/plain; charset="utf-8" RT-Send-CC: Content-Length: 576 I pushed one more fix and one more tweak. The former is hardly disputable because not applying it results in a compilation error when --enable-dnstap is used. As for the latter, I feel being explicit about the return value makes the code a bit more clear (and consistent with earlier returns in that function) and relieves the reader from having to scroll up in search of possible values of result. Feel free to disagree, though. I am happy with how the code looks now. I assume unit tests for all these elegant helper functions are coming along with comments, right? :)