References: <20170802031131.GA63960@isc.org> <20170802211456.GD72046@isc.org> Delivered-To: bind9-public@bugs.isc.org X-RT-Interface: Email MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Date: Fri, 4 Aug 2017 08:18:35 +0000 To: "Michal Kepien via RT" content-type: text/plain; charset="utf-8" Subject: Re: [ISC-Bugs #45362] resolver.c refactoring Received: from bikeshed.isc.org (bikeshed.isc.org [IPv6:2001:4f8:3:d::19]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mail.isc.org", Issuer "RapidSSL CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 75218D78AA1 for ; Fri, 4 Aug 2017 08:18:35 +0000 (UTC) Received: by bikeshed.isc.org (Postfix, from userid 10292) id 32B30216C1E; Fri, 4 Aug 2017 08:18:35 +0000 (UTC) X-RT-Incoming-Encryption: Not encrypted From each@isc.org Fri Aug 4 08:18:35 2017 X-RT-Original-Encoding: utf-8 From: "Evan Hunt" Content-Disposition: inline Return-Path: CC: X-Original-To: bind9-public@bugs.isc.org Message-ID: <20170804081835.GA62274@isc.org> RT-Message-ID: Content-Length: 464 As we discussed in jabber, the comments have now been pushed, and several of the rctx functions have been renamed for clarity. I didn't make any functional changes in that big commit (I promise) so if you just read the comments and they make sense, I think it's fine. An additional small functional change was made after that. Unit tests aren't coming now, but they'll be considerably more doable after this is committed and hopefully we'll get to them later.