X-RT-Incoming-Encryption: Not encrypted In-Reply-To: To: "Tony Finch via RT" X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org References: X-RT-Interface: Email MIME-Version: 1.0 Date: Mon, 14 Aug 2017 15:08:15 +0530 Subject: Re: [ISC-Bugs #45435] [PATCH] Deprecate dns_name_hashbylabel() since it isn't a very good hash. From: "Mukund Sivaraman" X-Original-To: bind9-confidential@bugs.isc.org Return-Path: Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 1CC88D78AE6 for ; Mon, 14 Aug 2017 09:38:26 +0000 (UTC) Received: from mail.banu.com (mail.banu.com [46.4.129.225]) by mx.pao1.isc.org (Postfix) with ESMTP id DAFB034AE58 for ; Mon, 14 Aug 2017 09:38:23 +0000 (UTC) Received: from jurassic (unknown [115.117.170.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.banu.com (Postfix) with ESMTPSA id A5CC056A0829; Mon, 14 Aug 2017 09:38:20 +0000 (GMT) Delivered-To: bind9-confidential@bugs.isc.org User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 content-type: text/plain; charset="utf-8" X-RT-Original-Encoding: utf-8 From muks@isc.org Mon Aug 14 09:38:26 2017 Message-ID: <20170814093815.GA12494@jurassic> Content-Disposition: inline RT-Message-ID: Content-Length: 679 Hi Tony On Wed, Jun 21, 2017 at 05:41:34PM +0000, Tony Finch via RT wrote: > The rbt stopped using it in 2004 (change 1740) and it was > not used after that point until RRL started using it in 2013. I'm keeping the dns_name_hashbylabel() function as-is, but have updated lib/dns/rrl.c to use dns_fullname_hash() as hashbylabel()'s use is not necessary there. > I have left the entry points in place for backwards compatibility, > though the hash values will be different. > + return (dns_name_fullhash(name, case_sensitive)); The two aren't equivalent. There's a thought to use something like this in rbt.c again to do incremental hashing during forest traversal. Mukund