User-Agent: Mutt/1.8.3 (2017-05-23) Content-Disposition: inline From: "Mukund Sivaraman" Subject: Re: [ISC-Bugs #45435] [PATCH] Deprecate dns_name_hashbylabel() since it isn't a very good hash. Return-Path: From muks@isc.org Mon Aug 14 09:42:51 2017 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Date: Mon, 14 Aug 2017 15:12:44 +0530 Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id E35FDD78AE6 for ; Mon, 14 Aug 2017 09:42:50 +0000 (UTC) Received: from mail.banu.com (mail.banu.com [IPv6:2a01:4f8:140:644b::225]) by mx.pao1.isc.org (Postfix) with ESMTP id D144F34AE60 for ; Mon, 14 Aug 2017 09:42:48 +0000 (UTC) Received: from jurassic (unknown [115.117.170.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.banu.com (Postfix) with ESMTPSA id 45F1E56A0808; Mon, 14 Aug 2017 09:42:47 +0000 (GMT) X-RT-Incoming-Encryption: Not encrypted To: "Mukund Sivaraman via RT" X-Original-To: bind9-public@bugs.isc.org X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org In-Reply-To: X-RT-Interface: Email Delivered-To: bind9-public@bugs.isc.org Message-ID: <20170814094244.GA12723@jurassic> References: <20170814093815.GA12494@jurassic> X-RT-Original-Encoding: utf-8 content-type: text/plain; charset="utf-8" RT-Message-ID: Content-Length: 508 On Mon, Aug 14, 2017 at 09:38:29AM +0000, Mukund Sivaraman via RT wrote: > Hi Tony > > On Wed, Jun 21, 2017 at 05:41:34PM +0000, Tony Finch via RT wrote: > > The rbt stopped using it in 2004 (change 1740) and it was > > not used after that point until RRL started using it in 2013. > > I'm keeping the dns_name_hashbylabel() function as-is, but have updated > lib/dns/rrl.c to use dns_fullname_hash() as hashbylabel()'s use is not s/dns_fullname_hash()/dns_name_fullhash()/ > necessary there. Mukund