In-Reply-To: <rt-4.4.1-80685-1502957089-668.45802-0-0@isc.org>
MIME-Version: 1.0
Content-Disposition: inline
X-Mailer: MIME-tools 5.508 (Entity 5.508)
X-RT-Interface: Web
X-RT-Original-Encoding: utf-8
Content-Transfer-Encoding: binary
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.4.1-19454-1503374265-1977.45802-0-0@isc.org>
References: <RT-Ticket-45802@isc.org> <20170817074309.GA13444@jurassic>
 <rt-4.4.1-80689-1502955801-1009.45802-3-0@isc.org>
 <20170817080438.GA15109@jurassic>
 <rt-4.4.1-80685-1502957089-668.45802-0-0@isc.org>
RT-Send-CC:
Content-Length: 855

On Wed Aug 16 22:04:49 2017, muks wrote:
> Please see rt45802, and results of root zone perfomance test here:
> 
> https://perflab.isc.org/#/run/test/59954c506a9745f45d95486f/
> 
> It offers a very modest performance improvement of single digit
> kQPS. Before I write unit tests for dns_name_towire2(), do we want to
> keep this?
> 
> 		Mukund

Moved DNS_NAMEATTR_NOCOMPRESS and DNS_COMPRESS_GLOBAL14
tests be done in the first if and unconditional save the offset if the pointer
is present.  This allows for future code to change these flags between calls to
dns_name_towire2.

*comp_offsetp needs to be set to the original value of go if gp.length == 0 or
otherwise you end up with a pointer to a pointer.

I've got no problems with keeping it.  If we ever preserve owner names on a per
record basis we can back this out then.

Anyway look at 8144b8d7f8