MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: MIME-tools 5.508 (Entity 5.508) References: <20170227041130.33E766544B34@rock.dv.isc.org> Content-Disposition: inline X-RT-Original-Encoding: utf-8 In-Reply-To: Content-Transfer-Encoding: binary Message-ID: X-RT-Interface: Web RT-Send-CC: Content-Length: 1430 > On Tue Aug 22 13:48:56 2017, michal wrote: > > I implemented two things in rt44754: > > > > - an additional sysctl-based runtime check for TCP Fast Open support > > on FreeBSD, as suggested by Francis, which logs a one-time notice if > > TCP Fast Open support is available, but disabled by sysctl, > > => seems good but it needs to be check on FreeBSD (I have a FreeBSD VM > if required but IMHO the best should be to ask the reporter...). I checked it on a FreeBSD VM before submitting, but I agree it would be best if Mathieu reviewed it as well. Mathieu, if we send you a patch, would you be willing to test it? > > - a configure option to forcibly disable TCP Fast Open support, as > > suggested in #45376. > > => s/autodetect/auto/ (mostly to be consistent with similar existing options). Well, we are hardly consistent in this regard. In fact, current master has two --enable-* options with "default=autodetect" (--enable-atomic, --enable-ipv6) and just one with "default=auto" (--enable-epoll). "auto" is only used as an implicit default value for --with-* options when they are not specified on the ./configure command line. That being said, I am happy to open another ticket to make the default values consistent. > Note you did not regenerate configure. Well, yes, as it should be automatically regenerated upon a git push which involves configure.in. See "git log --grep regen configure".