Date: Fri, 1 Sep 2017 10:05:00 +0200 Subject: Re: [ISC-Bugs #44754] TCP_FASTOPEN, again. Content-Transfer-Encoding: quoted-printable Content-Language: fr User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 In-Reply-To: X-Original-To: bind9-public@bugs.isc.org To: bind9-public@isc.org Return-Path: X-RT-Original-Encoding: utf-8 X-RT-Incoming-Encryption: Not encrypted content-type: text/plain; charset="utf-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Delivered-To: bind9-public@bugs.isc.org MIME-Version: 1.0 X-RT-Interface: Email Message-ID: <5b169096-a6c8-a998-4fe9-d6a6168523c4@FreeBSD.org> From: "Mathieu Arnold" From mat@FreeBSD.org Fri Sep 1 08:05:05 2017 References: <20170227041130.33E766544B34@rock.dv.isc.org> Organization: Absolight / The FreeBSD Foundation X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 74F3DD78AFC for ; Fri, 1 Sep 2017 08:05:05 +0000 (UTC) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id C05C034B319 for ; Fri, 1 Sep 2017 08:05:06 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 16BDCBDD37 for ; Fri, 1 Sep 2017 10:05:03 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id D1EF7BDD31 for ; Fri, 1 Sep 2017 10:05:02 +0200 (CEST) RT-Message-ID: Content-Length: 1549 Le 01/09/2017 à 09:09, Michał Kępień via RT a écrit : >> On Tue Aug 22 13:48:56 2017, michal wrote: >>> I implemented two things in rt44754: >>> >>> - an additional sysctl-based runtime check for TCP Fast Open support >>> on FreeBSD, as suggested by Francis, which logs a one-time notice if >>> TCP Fast Open support is available, but disabled by sysctl, >> => seems good but it needs to be check on FreeBSD (I have a FreeBSD VM >> if required but IMHO the best should be to ask the reporter...). > I checked it on a FreeBSD VM before submitting, but I agree it would be > best if Mathieu reviewed it as well. > > Mathieu, if we send you a patch, would you be willing to test it? Of course. >>> - a configure option to forcibly disable TCP Fast Open support, as >>> suggested in #45376. >> => s/autodetect/auto/ (mostly to be consistent with similar existing options). > Well, we are hardly consistent in this regard. In fact, current master > has two --enable-* options with "default=autodetect" (--enable-atomic, > --enable-ipv6) and just one with "default=auto" (--enable-epoll). > "auto" is only used as an implicit default value for --with-* options > when they are not specified on the ./configure command line. > > That being said, I am happy to open another ticket to make the default > values consistent. > >> Note you did not regenerate configure. > Well, yes, as it should be automatically regenerated upon a git push > which involves configure.in. See "git log --grep regen configure". > > -- Mathieu Arnold