Content-Transfer-Encoding: binary Content-Type: text/plain; charset="utf-8" In-Reply-To: X-RT-Original-Encoding: utf-8 Content-Disposition: inline X-Mailer: MIME-tools 5.508 (Entity 5.508) X-RT-Interface: Web References: Message-ID: MIME-Version: 1.0 RT-Send-CC: Content-Length: 788 After merging to current master, the version that uses #include "../tsig.c" no longer compiles due to shadowed global variables. Earlier, Mark and I discussed the best method for unit testing static functions, and he convinced me that it's okay to use the direct-include method in relatively simple cases, where the file is small and including it isn't going to cause namespace problems with the unit test. But that seems no longer to be the case here. So, because I want to get this merged for alpha, I reverted back to using double-underscore, non-static functions. However, I created a tsig_p.h instead of having the prototypes be in the public tsig.h. 4701. [cleanup] Refactored lib/dns/tsig.c to reduce code duplication and simplify the disabling of MD5. [RT #45490] 9.12.0