Content-Disposition: inline
From: "Evan Hunt" <each@isc.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Delivered-To: bind9-public@bugs.isc.org
Message-ID: <20170908171014.GB44967@isc.org>
content-type: text/plain; charset="utf-8"
X-RT-Interface: Email
In-Reply-To: <rt-4.4.1-11997-1504871363-1939.45186-5-0@isc.org>
References: <RT-Ticket-45186@isc.org> <rt-4.2.8-2611-1493950528-1432.45186-4-0@isc.org> <rt-4.2.8-30801-1495916960-592.45186-4-0@isc.org> <rt-4.4.1-30483-1504183952-736.45186-4-0@isc.org> <20170906205101.GA82383@isc.org> <rt-4.4.1-4999-1504731064-1974.45186-5-0@isc.org> <rt-4.4.1-11997-1504871363-1939.45186-5-0@isc.org>
X-RT-Original-Encoding: utf-8
MIME-Version: 1.0
From each@isc.org  Fri Sep  8 17:10:16 2017
Content-Transfer-Encoding: 8bit
To: "Michał Kępień via RT" <bind9-public@isc.org>
Return-Path: <each@isc.org>
Date: Fri, 8 Sep 2017 17:10:14 +0000
X-RT-Incoming-Encryption: Not encrypted
Subject: Re: [ISC-Bugs #45186] name server library
X-Original-To: bind9-public@bugs.isc.org
Received: from bikeshed.isc.org (bikeshed.isc.org [149.20.48.19]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mail.isc.org", Issuer "RapidSSL CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 005DED78B04 for <bind9-public@bugs.isc.org>; Fri,  8 Sep 2017 17:10:16 +0000 (UTC)
Received: by bikeshed.isc.org (Postfix, from userid 10292) id B8ACD216C1E; Fri,  8 Sep 2017 17:10:14 +0000 (UTC)
RT-Message-ID: <rt-4.4.1-11937-1504890616-70.45186-0-0@isc.org>
Content-Length: 1192

On Fri, Sep 08, 2017 at 11:49:24AM +0000, Michał Kępień via RT wrote:
> I pushed three more trivial commits which take care of things that you
> seem to have missed.  If you left these changes out deliberately, feel
> free to revert them.

I did leave the sctx assignments in get_client() and get_worker() on
purpose, purely out of an abundance of caution. They're probably not
necessary, but seemed like cheap insurance.

> Other than that, the only outstanding item is that there is no
> rt45186_base tag.  However, I understand rt45186 will need to be rebased
> on top of current master anyway and thus I think it is okay to refrain
> from creating the tag until that happens.

We used to create _base tags for everything when we used CVS, and continued
the practice for a while after switching to git, but a few years ago we
agreed it wasn't necessary except when branching from a source other than
master. Ordinarily, "git diff master...<branch>" is the same as
"git diff <branch>_base".

> In other words, I think the changes are good to go in their current
> state, though please do not forget to eventually properly comment all
> functions defined in libns header files.

Thanks!