From: "Mark Andrews" X-RT-Incoming-Encryption: Not encrypted X-Original-To: bind9-public@bugs.isc.org X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 From marka@isc.org Fri Sep 22 02:32:05 2017 Delivered-To: bind9-public@bugs.isc.org To: bind9-public@isc.org Subject: Re: [ISC-Bugs #46053] Comment zone functions related to NSEC3 processing content-type: text/plain; charset="utf-8" Date: Fri, 22 Sep 2017 12:31:25 +1000 Message-ID: <20170922023125.B875A87A01EF@rock.dv.isc.org> Return-Path: Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 172A5D78B08 for ; Fri, 22 Sep 2017 02:32:05 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 8A68534A96A for ; Fri, 22 Sep 2017 02:31:28 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id 7699516003D for ; Fri, 22 Sep 2017 02:31:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 656B5160069 for ; Fri, 22 Sep 2017 02:31:28 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id m4INksr_S1PS for ; Fri, 22 Sep 2017 02:31:28 +0000 (UTC) Received: from rock.dv.isc.org (c27-253-115-14.carlnfd2.nsw.optusnet.com.au [27.253.115.14]) by zmx1.isc.org (Postfix) with ESMTPSA id 21C7816003D for ; Fri, 22 Sep 2017 02:31:28 +0000 (UTC) Received: from rock.dv.isc.org (localhost [IPv6:::1]) by rock.dv.isc.org (Postfix) with ESMTP id B875A87A01EF for ; Fri, 22 Sep 2017 12:31:25 +1000 (AEST) X-RT-Interface: Email References: In-Reply-To: Your message of "Thu, 21 Sep 2017 07:33:51 +0000." X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx.pao1.isc.org X-RT-Original-Encoding: utf-8 RT-Message-ID: Content-Length: 537 In message , "=?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= via RT" writes: > To avoid code duplication, I extracted the hex-formatting code into a > separate function. Please review. cherry-picked atomic fixes so I could build it. Pushed a fix for completeness. Looks good to go. > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46053 -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org