Date: Tue, 26 Sep 2017 15:30:32 +0100
X-RT-Interface: Email
References: <RT-Ticket-45612@isc.org> <rt-4.4.1-51424-1500987795-1910.45612-4-0@isc.org> <rt-4.4.1-30483-1504156813-51.45612-4-0@isc.org> <20170901014934.1370583EC741@rock.dv.isc.org> <20170901084536.0CAB883FA1F0@rock.dv.isc.org> <rt-4.4.1-42271-1504255544-134.45612-4-0@isc.org> <6d45311c-8921-8f95-f56c-8acb1c00e8d6@isc.org> <rt-4.4.1-4791-1505752964-1360.45612-4-0@isc.org> <20170919021019.41193869E4AD@rock.dv.isc.org> <rt-4.4.1-8276-1505787037-74.45612-4-0@isc.org> <rt-4.4.1-23257-1506433614-869.45612-4-0@isc.org>
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1
X-RT-Original-Encoding: utf-8
Subject: Re: [ISC-Bugs #45612] Implement draft-durand-doa-over-dns
Content-Language: en-US
Return-Path: <ray@isc.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
X-Original-To: bind9-public@bugs.isc.org
To: bind9-public@isc.org
From ray@isc.org  Tue Sep 26 14:32:20 2017
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.ams1.isc.org
In-Reply-To: <rt-4.4.1-23257-1506433614-869.45612-4-0@isc.org>
Delivered-To: bind9-public@bugs.isc.org
content-type: text/plain; charset="utf-8"
Received: from mx.ams1.isc.org (mx.ams1.isc.org [199.6.1.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mx.ams1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 41484D78B0A for <bind9-public@bugs.isc.org>; Tue, 26 Sep 2017 14:32:20 +0000 (UTC)
Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.ams1.isc.org (Postfix) with ESMTPS id 3A0B124AE8F for <bind9-public@isc.org>; Tue, 26 Sep 2017 14:30:27 +0000 (UTC)
Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id A7F9E160052 for <bind9-public@isc.org>; Tue, 26 Sep 2017 14:30:34 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 72EAA16007E for <bind9-public@isc.org>; Tue, 26 Sep 2017 14:30:34 +0000 (UTC)
Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VjocDa1xcBxX for <bind9-public@isc.org>; Tue, 26 Sep 2017 14:30:34 +0000 (UTC)
Received: from rays-mbp.local (unknown [46.227.151.81]) by zmx1.isc.org (Postfix) with ESMTPSA id EFCB6160052 for <bind9-public@isc.org>; Tue, 26 Sep 2017 14:30:33 +0000 (UTC)
Message-ID: <33cf37b8-85c1-ba7e-dd19-01a16523c529@isc.org>
From: "Ray Bellis" <ray@isc.org>
X-RT-Incoming-Encryption: Not encrypted
MIME-Version: 1.0
RT-Message-ID: <rt-4.4.1-23257-1506436341-818.45612-0-0@isc.org>
Content-Length: 420

On 26/09/2017 14:46, Michał Kępień via RT wrote:
> Pushed some more bikeshedding that should be a blast to review.  Working
> on making lib/dns/tests/rdata_test.c check totext_*() functions as well.

I don't see any unit tests that allow for spaces to appear within the
DOA-DATA base64, and I'm not familiar enough with our tokenizer to know
whether the new call to isc_lex_getmastertoken() handles that for us.