X-Mailer: MIME-tools 5.508 (Entity 5.508) References: <20170928191216.GA18050@jurassic> MIME-Version: 1.0 X-RT-Interface: Web Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: binary In-Reply-To: Content-Disposition: inline X-RT-Original-Encoding: utf-8 Message-ID: RT-Send-CC: Content-Length: 923 > 16:58:28 ray@jabber.isc.org: it feels brittle, compared to using a > library that ensures that your tags get closed, and that all values > are correctly escaped > 16:58:43 bconry: when you use a library you're letting (supposed) > experts in the format make sure that your output will be legal > 16:59:07 bconry: when you roll your own you're trusting yourself and > all future maintainers to be expert enough in the format to not make > any mistakes > 16:59:10 ray@jabber.isc.org: last big project I worked on before ISC, > I insisted that the new version of the code use an existing JSON > library rather than hand-code it I agree with these objections. I think we can probably improve code readability by writing subsidiary functions that handle the opening and closing of tags, but I don't want to risk BIND producing improperly sanitized XML. I *love* isc_buffer_printf() though! Let's definitely keep that idea.