In-Reply-To: Content-Transfer-Encoding: binary Message-ID: MIME-Version: 1.0 X-RT-Interface: Web X-RT-Original-Encoding: utf-8 Content-Disposition: inline References: Content-Type: text/plain; charset="utf-8" X-Mailer: MIME-tools 5.508 (Entity 5.508) RT-Send-CC: Content-Length: 1442 Branch rt46173: - extends lib/ns/tests/nstest.c with a few convenience functions, one of which allows easy creation of mock query contexts for specified query parameters, - implements a basic hook architecture for libns; while the primary objective of doing this was limiting unit test scope, implementation attempts to be as generic as possible due to Evan's suggestion from Jabber that such a concept might be useful in a wider context in the future, - uses the mechanisms mentioned above to implement unit tests for query_sfcache() and query_start(), - extends code comments for these two functions. I would personally recommend to review this commit by commit as these are laid out in a way which attempts to convey the process of putting all the involved parts together and most commits have log messages attached that provide additional context for introducing any given change. Code is also heavily commented. While only two functions are covered by the unit tests currently present in rt46173, the sheer amount of helper code added in that branch strongly indicates that a review is due, at least to sign off on the high-level approach to unit testing libns. If anyone finds the proposed techniques faulty, it will be better to make the necessary course correction now, before the line count for code that performs actual unit testing increases even more. Any thoughts on this are welcome.