Received: from bikeshed.isc.org (bikeshed.isc.org [149.20.48.19]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mail.isc.org", Issuer "RapidSSL CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 79C5AD78B0A for <bind9-public@bugs.isc.org>; Fri,  6 Oct 2017 17:42:48 +0000 (UTC)
Received: by bikeshed.isc.org (Postfix, from userid 10292) id 4FAB4216C1E; Fri,  6 Oct 2017 17:42:48 +0000 (UTC)
Return-Path: <each@isc.org>
In-Reply-To: <rt-4.4.1-34921-1507297383-1024.46201-4-0@isc.org>
X-RT-Interface: Email
User-Agent: Mutt/1.5.23 (2014-03-12)
To: "Michał Kępień via RT" <bind9-public@isc.org>
MIME-Version: 1.0
X-RT-Incoming-Encryption: Not encrypted
From each@isc.org  Fri Oct  6 17:42:48 2017
Delivered-To: bind9-public@bugs.isc.org
References: <RT-Ticket-46201@isc.org> <rt-4.4.1-21557-1507204871-466.46201-4-0@isc.org> <rt-4.4.1-24010-1507232188-773.46201-4-0@isc.org> <rt-4.4.1-34921-1507297383-1024.46201-4-0@isc.org>
Content-Transfer-Encoding: 8bit
content-type: text/plain; charset="utf-8"
From: "Evan Hunt" <each@isc.org>
Date: Fri, 6 Oct 2017 17:42:48 +0000
X-RT-Original-Encoding: utf-8
Content-Disposition: inline
Message-ID: <20171006174248.GD76109@isc.org>
X-Original-To: bind9-public@bugs.isc.org
Subject: Re: [ISC-Bugs #46201] Add isc_buffer_printf()
CC: 
RT-Message-ID: <rt-4.4.1-26415-1507311769-399.46201-0-0@isc.org>
Content-Length: 495

On Fri, Oct 06, 2017 at 01:43:03PM +0000, Michał Kępień via RT wrote:
> Once you are happy with the end result, please let me know and I
> will merge it.

My only comment is that isc_httpd_*() functions were previously always
returning ISC_R_SUCCESS and now they aren't. I do think that's an
improvement, but my thought was to leave the behavior of those
functions identical.

However, since the result codes aren't being caught by the caller
anyway, let's go ahead with it.

Okay to merge.