X-RT-Incoming-Encryption: Not encrypted From muks@isc.org Mon Oct 9 05:55:27 2017 Message-ID: <20171009055517.GA17733@jurassic> X-RT-Original-Encoding: utf-8 In-Reply-To: References: <20170422061525.GA20756@jurassic> Subject: Re: [ISC-Bugs #45123] Add memory context flag for memfill with pattern after allocs/frees X-RT-Interface: Email X-Original-To: bind9-public@bugs.isc.org Date: Mon, 9 Oct 2017 11:25:17 +0530 To: "Evan Hunt via RT" X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 MIME-Version: 1.0 Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 6BF77D78B0C for ; Mon, 9 Oct 2017 05:55:27 +0000 (UTC) Received: from mail.banu.com (mail.banu.com [46.4.129.225]) by mx.pao1.isc.org (Postfix) with ESMTP id 86DEE3AC73C for ; Mon, 9 Oct 2017 05:55:25 +0000 (UTC) Received: from jurassic (unknown [115.118.56.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.banu.com (Postfix) with ESMTPSA id A695056A02C7; Mon, 9 Oct 2017 05:55:22 +0000 (GMT) Delivered-To: bind9-public@bugs.isc.org content-type: text/plain; charset="utf-8" Content-Disposition: inline Return-Path: From: "Mukund Sivaraman" User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org RT-Message-ID: Content-Length: 330 The branch looks good. I've pushed a typo fix. I guess this can't be system tested. Maybe the default memfill can be unit tested in isc_mem_get() to check that it is performed, but it can't be deterministically unit tested to check that the filling is not performed. It would also depend on the compile configuration. Mukund