X-RT-Incoming-Encryption: Not encrypted X-Original-To: bind9-public@bugs.isc.org User-Agent: Mutt/1.9.1 (2017-09-22) Return-Path: Subject: Use isc_rng_random32() instead of combining two 16-bit values in various places From muks@isc.org Mon Oct 9 11:52:45 2017 content-type: text/plain; charset="utf-8" X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org Delivered-To: bind9-public@bugs.isc.org Message-ID: <20171009115236.GA5154@jurassic> To: bind-suggest@isc.org From: "Mukund Sivaraman" Content-Disposition: inline Date: Mon, 9 Oct 2017 17:22:36 +0530 MIME-Version: 1.0 Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 40E4DD78B0A for ; Mon, 9 Oct 2017 11:52:45 +0000 (UTC) Received: from mail.banu.com (mail.banu.com [46.4.129.225]) by mx.pao1.isc.org (Postfix) with ESMTP id 4E15B3AC896 for ; Mon, 9 Oct 2017 11:52:43 +0000 (UTC) Received: from jurassic (unknown [115.118.56.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.banu.com (Postfix) with ESMTPSA id 1FD5A56A00EA; Mon, 9 Oct 2017 11:52:40 +0000 (GMT) X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-RT-Original-Encoding: ascii X-RT-Interface: Email Content-Length: 191 When the old isc_random_get() was replaced with isc_rng_random(), a function should have been created to return a 32-bit value than combining two 16-bit values in various parts of the code.