X-Mailer: MIME-tools 5.508 (Entity 5.508) In-Reply-To: X-RT-Interface: Web References: Content-Type: text/plain; charset="utf-8" X-RT-Original-Encoding: utf-8 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: binary Content-Disposition: inline RT-Send-CC: Content-Length: 737 It just occurred to me I should update status in the ticket... I reviewed this work via jabber the other evening. By and large I think it's excellent and should be merged. Sometime soon I'd like us to have a longer conversation about how this could be developed into the general-purpose hook architecture we had tentatively envisioned for 9.13. We may need to tweak the interface to allow for future uses and it would be better to do that now rather than later, when there may be many more unit tests that would need to be changed. However, that needn't prevent us from committing it now as it is. I made some specific suggestions for clarifications to the comments and am waiting for Michal to do those. Otherwise this is ok to merge.